Confirmation Button Dialog not working when used within a wider script

Ah, yes. The Clip List ui went through some changes on Pro Tools 2024.10 when they made it detachable.

We can address the UI differently for different versions with this bit of code:

const ptVersion = sf.ui.proTools.appVersionAsNumber;
let clipListPopupMenu;
if (ptVersion < 241000) {
    clipListPopupMenu = sf.ui.proTools.mainWindow.popupButtons.whoseTitle.is("Clip List").first;
} else {
    clipListPopupMenu = sf.ui.proTools.mainWindow.popupButtons.whoseTitle.is("Show Options menu").first;
}

This version of the script should work on both 2024.6 and 2024.10 and includes the for loop for extra clearing:

// Pro Tools Start Script
if (!sf.ui.proTools.isRunning) throw 'Pro Tools is not running';
sf.ui.proTools.appActivateMainWindow();
sf.ui.proTools.mainWindow.invalidate();

const ptVersion = sf.ui.proTools.appVersionAsNumber;
let clipListPopupMenu;
if (ptVersion < 241000) {
    clipListPopupMenu = sf.ui.proTools.mainWindow.popupButtons.whoseTitle.is("Clip List").first;
} else {
    clipListPopupMenu = sf.ui.proTools.mainWindow.popupButtons.whoseTitle.is("Show Options menu").first;
}

//FUNCTIONS------------------------------------------------------------------------------------------------
//Clear Clips List Filter
function clearClipsListFilter() {
    const clipsFilterPlate = sf.ui.proTools.mainWindow.buttons.whoseTitle.is("Plate");
    const clearClipsFilterButton = clipsFilterPlate.allItems.whoseValue.is("Clear Search Text").first;

    if (clearClipsFilterButton.exists) {
        clearClipsFilterButton.elementClick({}, `Failed clearing the Clips List filter text field.`);
    }
}

// Go to Session Start
function goToSessionStart() {
    sf.app.proTools.setTimelineSelection({
        inTime: String(Number(0)),
        outTime: String(Number(0)),
    });
}

//------------------------------------------------------------------------------------------------


function main() {

    // CHANGE SESSION START TO FIRST CLIP IN SESSION
    goToSessionStart();

    // Select all tracks
    let ptTracks = sf.app.proTools.tracks.invalidate().allItems.map(track => track.name);
    sf.app.proTools.selectTracksByName({ trackNames: ptTracks, selectionMode: "Replace" });

    // Select first clip on the timeline and store it's location
    sf.ui.proTools.clipSelectNextFullClip();
    let currentTimelineSelection = sf.app.proTools.getTimelineSelection({ timeScale: "Samples" });

    // Go to the start of the first clip
    sf.app.proTools.setTimelineSelection({
        inTime: String(Number(currentTimelineSelection.inTime)),
        outTime: String(Number(currentTimelineSelection.inTime)),
    });

    // Get Current Timeline Selection as Timecode
    currentTimelineSelection = sf.app.proTools.getTimelineSelection({ timeScale: "TimeCode" });

    // Open Session Setup
    if (!sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.exists) {
        sf.ui.proTools.menuClick({
            menuPath: ["Setup", "Session"],
        });

        sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.elementWaitFor();
    }

    // Set the Session Start time to the timecode position of the first clip. If it's already set, then move on. 
    if (sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.groups.whoseTitle.is("Session Format").first.textFields.whoseTitle.is("NumericEntryText").first.value.invalidate().value !== currentTimelineSelection.inTime) {
        // Select the text field for "Session Start"
        sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.groups.whoseTitle.is("Session Format").first.textFields.whoseTitle.is("NumericEntryText").first.elementClick()

        // We have to simulate typing for the "Session Start" field of the session setup window
        sf.keyboard.type({ text: currentTimelineSelection.inTime });

        //Wait until the correct timecode has been typed into the field
        while (sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.groups.whoseTitle.is("Session Format").first.textFields.whoseTitle.is("NumericEntryText").first.value.invalidate().value !== currentTimelineSelection.inTime) {
            sf.wait({
                intervalMs: 50,
            })
        }

        // Press Return to Complete Entering the Timecode in the Session Start Field
        sf.keyboard.press({ keys: 'return ' });

        // Wait for the confirmation dialog button
        sf.ui.proTools.confirmationButtonDialog.buttons.whoseTitle.is("Maintain timecode").first.elementWaitFor();

        // Click for the confirmation dialog button
        sf.ui.proTools.confirmationButtonDialog.buttons.whoseTitle.is("Maintain timecode").first.elementClick();
    }

    // If the Session Setup window is open, close the window
    if (sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.exists) {

        sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.getElement("AXCloseButton").elementClick();

        sf.ui.proTools.windows.whoseTitle.is("Session Setup").first.elementWaitFor({
            waitType: "Disappear",
        });
    }

    // DESELECT ALL TRACKS
    sf.app.proTools.selectTracksByName({ trackNames: [], selectionMode: "Replace" });

    // Make sure the clip list is shown
    sf.ui.proTools.menuClick({
        menuPath: ["View", "Other Displays", "Clip List"],
        targetValue: "Enable"
    });

    //CLEAR UN-USED CLIPS --- BROKEN -- Same Code Works on it's own?

    clearClipsListFilter();

    //Adjust Clip List Filters (From @Chris_Shaw)

    // Create an Object of items to for the clip list filter to include
    const itemsToCheck = {
        "Audio": true,
        "MIDI": true,
        "Video": true,
        "Groups": true,
        "Auto-Created": true,
        "Include subsequently added clips": false,
    }

    // Set Clip List filter checkboxes
    const clipListFilterOptionsPopup = sf.ui.proTools.mainWindow.buttons.whoseValue.is("Show Filter Options").first;

    const filterCheckBoxes = clipListFilterOptionsPopup.popupMenuFetchAllItems().menuItems;

    const checkBoxes = Object.keys(itemsToCheck)

    checkBoxes.forEach(cb => {
        const checkBox = filterCheckBoxes.filter(mi => mi.path[0].endsWith(cb)).map(i => i.element)[0];

        const shouldClick =
            checkBox.isMenuChecked !== itemsToCheck[cb] ||
            typeof itemsToCheck[cb] !== "boolean"

        if (shouldClick) checkBox.elementClick();
    })

    // Quick Little UI refresh
    sf.ui.proTools.appActivateMainWindow();

    //Clears up to a maximum of 15 times
    for (var i = 0; i < 15; i++) {
        clipListPopupMenu.popupMenuSelect({
            menuPath: ["Select", "Unused"],
            targetValue: "Enable"
        });

        clipListPopupMenu.popupMenuSelect({
            menuPath: ["Clear..."],
        })

        sf.wait({
            intervalMs: 300
        });

        if (!sf.ui.proTools.confirmationButtonDialog.exists) {
            //log("Nothing to do")
            sf.ui.proTools.appActivateMainWindow()
            break;
        } else {

            // We need to invalidate the confirmationButtonDialog cache
            // Also, We can wait for an element and then click it in one line.
            sf.ui.proTools.confirmationButtonDialog.invalidate().buttons.whoseTitle.is("Remove").first.elementWaitFor().element.elementClick();

            // Clear All
            if (sf.ui.proTools.confirmationDialog.buttons.whoseTitle.is("Yes").first.exists) {
                sf.ui.proTools.confirmationDialog.buttons.whoseTitle.is("Yes").first.mouseClickElement({
                    isOption: true,
                });
            }

            // This is a simple way we can wait for all dialogs to be gone
            sf.ui.proTools.waitForNoModals();
        }

    }

}

main();